fix: bandit flag with no allocations incorrectly returning programmatic default #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (banditEvaluation == null) { | ||
| logger.warn(`${loggerPrefix} No assigned variation. Bandit not found: ${flagKey}`); | ||
| return { variation: defaultValue, action: null }; | ||
| return { variation: this.getStringAssignment(flagKey, defaultValue), action: null }; |
There was a problem hiding this comment.
Did you consider adding a test for this situation?
There was a problem hiding this comment.
For precomputed, I think the change should be made the edge compute method, not this client.
Basically, part of the edge compute logic should be evaluating a bandit flag whether it has an active bandit allocation or not--not the responsibility of the downstream client.
For null, we'd do the same as getPrecomputedAssignment(), and do a check like:
if (assignedVariation == null) {
logger.warn(`[Eppo SDK] No assigned variation. Bandit flag not found: ${flagKey}`);
return defaultValue;
}But otherwise would expect something in the format { variation: <variation to return>, action: null} in that case
|
Closing as this isn't the right fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: FF-4105
Motivation and Context
A bandit flag is not returned in UFC when there are no allocations assigned to it, however the "default variation" is still desired in that scenario. Currently, the programmatic default is used.
Description
Updates
getBanditAction()so that it falls back to the flag evaluation if the bandit flag does not exist